Skip to content

Updated background and padding#19623

Merged
freben merged 1 commit into
backstage:masterfrom
awanlin:topic/add-white-bg-to-permission-diagram
Aug 31, 2023
Merged

Updated background and padding#19623
freben merged 1 commit into
backstage:masterfrom
awanlin:topic/add-white-bg-to-permission-diagram

Conversation

@awanlin

@awanlin awanlin commented Aug 26, 2023

Copy link
Copy Markdown
Collaborator

Hey, I just made a Pull Request!

Updated the permissions digram to have a white background and roughly 10px padding all around

Closes #19558

Before After
Screenshot 2023-08-26 at 5 47 28 PM Screenshot 2023-08-26 at 5 47 17 PM

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)

@awanlin
awanlin requested review from a team as code owners August 26, 2023 22:50
@awanlin
awanlin requested review from freben and vinzscam August 26, 2023 22:50
@github-actions github-actions Bot added the area:documentation Improvements or additions to documentation label Aug 26, 2023
@github-actions

github-actions Bot commented Aug 26, 2023

Copy link
Copy Markdown
Contributor

Uffizzi Preview deployment-34492 was deleted.

@camilaibs camilaibs left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the image 🙌🏻
Just left a question, nothing blocking this pull request 🙂

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to add a white background via CSS to all images as an alternative when the dark theme is active?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, @vinzscam suggested that in the related issue. I went this route as I felt that getting it fixed quickly was better then having it be really hard to read. Maybe we could log a more general Issue with a help wanted label to add this?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, I agree with you. Do you mind opening up the more general issue for us 🙏🏻 ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, did a quick look and found this: #17712. Would that work or should I log something new for this?

@freben freben left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging in the mean time!

@freben
freben merged commit a582c2a into backstage:master Aug 31, 2023
@awanlin
awanlin deleted the topic/add-white-bg-to-permission-diagram branch August 31, 2023 12:24
@awanlin

awanlin commented Aug 31, 2023

Copy link
Copy Markdown
Collaborator Author

Thanks @freben and @camilaibs 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 Bug Report: [Docs] Permission Diagram Hard to Read

3 participants