GitLab auth provider gets ID tokens and be used as a k8s oidcTokenProvider#16401
Conversation
Changed Packages
|
|
Uffizzi Preview |
7c62126 to
10317ff
Compare
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
politely pinging @Rugvip for review or referral to somebody else? |
Rugvip
left a comment
There was a problem hiding this comment.
Thank you! 👍
Makes sense, just a few nits
8dafc03 to
f5ebdec
Compare
The changeset justifies this choice Signed-off-by: Jamie Klassen <[email protected]>
Signed-off-by: Jamie Klassen <[email protected]>
Signed-off-by: Jamie Klassen <[email protected]>
f5ebdec to
8adeb19
Compare
|
@Rugvip I believe I've addressed all your open concerns, but did some force pushes so it might not be obvious how things have changed. Do you mind giving another look? |
Rugvip
left a comment
There was a problem hiding this comment.
Thank you! 👍
I agree the openid scope addition should be fine and maybe even avoids issues in some cases. I'll say that we'll be very quick to revert that change at the first sign of trouble though 😅
Let's ![]()
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
Hey, I just made a Pull Request!
The use case I wanted to support here is viewing
http://localhost:3000/catalog/default/component/demo-k8s-service/kubernetes, logging in via gitlab and successfully seeing kube-dns objects.The setup is extensive, including a kind cluster with config:
and app-config
where
kubernetes.yamliswhere
GITLAB_HOST,CLIENT_ID,CLIENT_SECRETandGITLAB_USERIDare hopefully self-explanatory!✔️ Checklist
Screenshots attached (for UI changes)n/aSigned-off-byline in the message. (more info)