Entity Feedback Plugin#15881
Conversation
Changed Packages
|
|
Uffizzi Preview |
a67fbc0 to
e1c1ff7
Compare
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
|
shoo stale bot 😠 |
camilaibs
left a comment
camilaibs
left a comment
There was a problem hiding this comment.
I easily see the rate incorporated in the search results score 🤩
|
This PR has been automatically marked as stale because it has not had recent activity from the author. It will be closed if no further activity occurs. If the PR was closed and you want it re-opened, let us know and we'll re-open the PR so that you can continue the contribution! |
Signed-off-by: Phil Kuang <[email protected]>
e1c1ff7 to
a3c86a7
Compare
Rugvip
left a comment
Rugvip
left a comment
There was a problem hiding this comment.
Sweet 😁 🎉
Loving the additions on top of 👍 / 👎 to make the feedback more valuable
Just some small nits.
Btw, do you mind adding yourself as codeowner of the packages as well? Just to keep track of it for now, but hopefully not too long now before it actually has an effect 😁 Will ofc ask again at that point
|
|
||
| <Grid item md={2}> | ||
| <InfoCard title="Rate this entity"> | ||
| <LikeDislikeButtons /> |
There was a problem hiding this comment.
Do you feel strongly about structuring it like this as opposed to exporting a EntityLikeDislikeCard? :>
There was a problem hiding this comment.
so the motivation behind this is to allow it to be more customizable in where the consumer wants to render these buttons. eg. internally we created a custom AboutCard and put the buttons there (AFAIK the API for a customizable AboutCard is still unsettled so wasn't sure if I should include in the demo app in that manner as an example):
There was a problem hiding this comment.
yep figured x), yeah it's really quite a lot nicer to have it on the AboutCard. Perhaps it's even worth calling it out in the README? Alright, let's leave as is
| @@ -0,0 +1,50 @@ | |||
| { | |||
| "name": "@backstage/plugin-entity-feedback-backend", | |||
| "version": "0.1.0", | |||
There was a problem hiding this comment.
Should start out the packages at 0.0.0, then they'll get bumped to 0.1.0 on the first release
| /** | ||
| * @public | ||
| */ | ||
| export interface Response { |
There was a problem hiding this comment.
Wonder if it might be better to call this FeedbackResponse or smth like tha?, there's some pretty direct overlap here 😅
Signed-off-by: Phil Kuang <[email protected]>
8a6e715 to
dfbe698
Compare
|
@Rugvip updated! thanks for taking the time to review! |
🎉
|
Thank you for contributing to Backstage! The changes in this pull request will be part of the |
4 participants
Signed-off-by: Phil Kuang [email protected]
New year, new plugin 🎉
Introducing the Entity Feedback plugin!
This simple plugin allows you to rate the quality of entities in your Backstage catalog. Why would you want to rate entities you ask? As a new adopter your first big hurdle might be building out your software catalog and ensuring your content is correct and up to date. Allowing your users to rate entities brings them into the feedback loop that can help notify owners if something is wrong with their entity (ie. taking inspiration of the feedback model of TechDocs 😁).
Screen.Recording.2023-01-20.at.10.47.07.PM.mov
Future Work / Enhancement Ideas
✔️ Checklist
Signed-off-byline in the message. (more info)