feat(node): pass generic function implementation to mockImplementation and mockImplementationOne

bacebu4 · bacebu4 · commit f53d3557b1f0 · 2024-06-20T08:50:56.000+02:00
diff --git a/types/node/test.d.ts b/types/node/test.d.ts
@@ -1031,7 +1031,7 @@ declare module "node:test" {
          * @since v19.1.0, v18.13.0
          * @param implementation The function to be used as the mock's new implementation.
          */
-        mockImplementation(implementation: Function): void;
+        mockImplementation(implementation: F): void;
         /**
          * This function is used to change the behavior of an existing mock for a single
          * invocation. Once invocation `onCall` has occurred, the mock will revert to
@@ -1068,7 +1068,7 @@ declare module "node:test" {
          * @param implementation The function to be used as the mock's implementation for the invocation number specified by `onCall`.
          * @param onCall The invocation number that will use `implementation`. If the specified invocation has already occurred then an exception is thrown.
          */
-        mockImplementationOnce(implementation: Function, onCall?: number): void;
+        mockImplementationOnce(implementation: F, onCall?: number): void;
         /**
          * Resets the call history of the mock function.
          * @since v19.3.0, v18.13.0
diff --git a/types/node/test/test.ts b/types/node/test/test.ts
@@ -772,6 +772,12 @@ class TestReporter extends Transform {
     }
 }
 const createdMock: Mock<() => undefined> = mock.fn(() => undefined);
+// @ts-expect-error
+createdMock.mock.mockImplementation(() => null);
+createdMock.mock.mockImplementation(() => undefined);
+// @ts-expect-error
+createdMock.mock.mockImplementationOnce(() => null);
+createdMock.mock.mockImplementationOnce(() => undefined);
 
 // Allows for typing of TestContext outside of a test
 const contextTest = (t: TestContext) => {
diff --git a/types/node/v18/test.d.ts b/types/node/v18/test.d.ts
@@ -729,7 +729,7 @@ declare module "node:test" {
          * This function is used to change the behavior of an existing mock.
          * @param implementation The function to be used as the mock's new implementation.
          */
-        mockImplementation(implementation: Function): void;
+        mockImplementation(implementation: F): void;
 
         /**
          * This function is used to change the behavior of an existing mock for a single invocation.
@@ -739,7 +739,7 @@ declare module "node:test" {
          * @param onCall The invocation number that will use `implementation`.
          *  If the specified invocation has already occurred then an exception is thrown.
          */
-        mockImplementationOnce(implementation: Function, onCall?: number): void;
+        mockImplementationOnce(implementation: F, onCall?: number): void;
 
         /**
          * Resets the call history of the mock function.

Original file line number	Diff line number	Diff line change
`@@ -772,6 +772,12 @@ class TestReporter extends Transform {`
`772`	`772`	`}`
`773`	`773`	`}`
`774`	`774`	`const createdMock: Mock<() => undefined> = mock.fn(() => undefined);`
	`775`	`+// @ts-expect-error`
	`776`	`+createdMock.mock.mockImplementation(() => null);`
	`777`	`+createdMock.mock.mockImplementation(() => undefined);`
	`778`	`+// @ts-expect-error`
	`779`	`+createdMock.mock.mockImplementationOnce(() => null);`
	`780`	`+createdMock.mock.mockImplementationOnce(() => undefined);`
`775`	`781`
`776`	`782`	`// Allows for typing of TestContext outside of a test`
`777`	`783`	`const contextTest = (t: TestContext) => {`