Skip to content

Commit 66b20f0

Browse files
fix(github): add request timeouts and safe per-response json parsing
1 parent a1cce4a commit 66b20f0

1 file changed

Lines changed: 19 additions & 9 deletions

File tree

‎src/lib/github.ts‎

Lines changed: 19 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -29,30 +29,40 @@ export async function getGitHubStats(): Promise<GitHubStats> {
2929
const [repoRes, prsRes] = await Promise.allSettled([
3030
fetch(REPO_URL, {
3131
headers,
32+
signal: AbortSignal.timeout(5000),
3233
next: { revalidate: 3600 },
3334
}),
3435
fetch(PRS_URL, {
3536
headers,
37+
signal: AbortSignal.timeout(5000),
3638
next: { revalidate: 3600 },
3739
}),
3840
]);
3941

4042
const stats: GitHubStats = { ...fallback };
4143

4244
if (repoRes.status === "fulfilled" && repoRes.value.ok) {
43-
const data = await repoRes.value.json();
44-
if (typeof data.stargazers_count === "number") {
45-
stats.stars = data.stargazers_count;
46-
}
47-
if (typeof data.forks_count === "number") {
48-
stats.forks = data.forks_count;
45+
try {
46+
const data = await repoRes.value.json();
47+
if (typeof data?.stargazers_count === "number") {
48+
stats.stars = data.stargazers_count;
49+
}
50+
if (typeof data?.forks_count === "number") {
51+
stats.forks = data.forks_count;
52+
}
53+
} catch {
54+
// preserve other metric if this JSON parse fails
4955
}
5056
}
5157

5258
if (prsRes.status === "fulfilled" && prsRes.value.ok) {
53-
const data = await prsRes.value.json();
54-
if (typeof data.total_count === "number") {
55-
stats.prs = data.total_count;
59+
try {
60+
const data = await prsRes.value.json();
61+
if (typeof data?.total_count === "number") {
62+
stats.prs = data.total_count;
63+
}
64+
} catch {
65+
// preserve other metric if this JSON parse fails
5666
}
5767
}
5868

0 commit comments

Comments
 (0)