Skip to content

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Apr 2, 2025

Docs PR for babel/babel#17217

@netlify
Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for babel-next ready!

Name Link
🔨 Latest commit bac97bf
🔍 Latest deploy log https://app.netlify.com/sites/babel-next/deploys/67eda8b8e9875300088fd453
😎 Deploy Preview https://deploy-preview-3075--babel-next.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Apr 2, 2025

Deploy Preview for babel ready!

Name Link
🔨 Latest commit bac97bf
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/67eda8b8e55ab00008852143
😎 Deploy Preview https://deploy-preview-3075--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.


__Migration__: Call `t.identifier` with a valid name.

- Reject invalid variable declarator in `t.variableDeclaration` builder ([#10917](https://github.com/babel/babel/pull/10917), [#17217](https://github.com/babel/babel/pull/17217))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#10917 was copied accidentally?

Copy link
Contributor Author

@JLHwung JLHwung Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment on lines 949 to 952
// highlight-error-next-line
t.variableDeclaration("var", [
t.variableDeclarator(t.arrayPattern([t.identifier("x")]))
]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe highlight these three lines?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we don't have highlight-error block. I will see if I can add it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also copy the comment three times. :)

@JLHwung JLHwung merged commit 7c0703d into babel:main Apr 3, 2025
4 checks passed
@JLHwung JLHwung deleted the add-17217-changelog branch April 3, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants