Bug fix - #772#778
Conversation
xtuc
left a comment
xtuc
left a comment
There was a problem hiding this comment.
Thanks for your pr.
lgtm apart of the linting.
There was a problem hiding this comment.
This doesn't work if the *= operator is inside a potential arrow function:
(a *= 2)(a = b *= 2): T => a
I'd suggest checking if this.state.exprAllowed is true: if an expression is expected, then *= is not allowed. Doing so would probably also fix the bug with class fields (class A { foo:*=2 })
|
right @nicolo-ribaudo good catch. |
This reverts commit afb76e6.
|
Can you also add a test for class properties? |
|
We moved babylon back into the monorepo at https://github.com/babel/babel/tree/master/packages/babylon. Unfortunately pull requests cannot be migrated between repositories automatically. If this PR is still valid please reopen it there. |
4 participants
Existential return type annot in arrow function confused with
*=operator