This repository was archived by the owner on May 19, 2018. It is now read-only.
Fix leading comments added from previous node #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue that comments were added as leading comments to expressions, which are not immediately folowing the comment. This was also reported and fixed in espree, and is basically a port to babylon. eslint/js#256 this also fixes an issue in babel-eslint with certain rules babel/babel-eslint#289
Member
|
I wrote the fixes for Espree and was planning on porting it over - looks like you beat me to it! |
|
Please accept this PR, as I am running into the issue mentioned in eslint/eslint issue #6090 |
|
Bump. Is there anyone available that can merge this PR? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue that comments were added as leading comments
to expressions, which are not immediately following the comment.
This example adds
//commentas leading comment toreturn a;This was also reported and fixed in espree, and is basically a port to
babylon. eslint/js#256
this also fixes an issue in babel-eslint with certain rules babel/babel-eslint#289
The only thing is that comments within jsx `{/* comment */} are now not added as leading comment anymore to the closingElement. I'm not really sure if thats wrong, as it is still added as innerComment.