Skip to content
This repository was archived by the owner on May 19, 2018. It is now read-only.

[7.0] Rename flow AST Type ExistentialTypeParam to ExistsTypeAnnotation #319

Closed
danez opened this issue Jan 22, 2017 · 7 comments
Closed

[7.0] Rename flow AST Type ExistentialTypeParam to ExistsTypeAnnotation #319

danez opened this issue Jan 22, 2017 · 7 comments
Labels
good first issue help wanted i: bug Tag: Breaking Change
Milestone
7.0.0

Comments

@danez
Copy link
Member

danez commented Jan 22, 2017 •
edited
Loading

Flow and babylon6 use a different node type for *

Example: http://astexplorer.net/#/INBlde78H0

babylon uses ExistentialTypeParam, whereas flow uses ExistsTypeAnnotation

We should change babylon and rename the node to use the same name as flow.

//cc @samwgoldman
@danez danez added this to the 7.0.0 milestone Jan 23, 2017
@AvraamMavridis
Copy link

Can I take this one?

This was referenced Jan 24, 2017
Merged
Merged
@existentialism
Copy link
Member

existentialism commented Jan 24, 2017 •
edited
Loading

@AvraamMavridis looks like @koba04 just published a PR =/ don't let that stop you from contributing on other babel/babylon issues and bugs!

@koba04
Copy link
Contributor

koba04 commented Jan 24, 2017

@AvraamMavridis I'm sorry, I missed your comment.

@AvraamMavridis
Copy link

@existentialism @koba04 no worries. :)

@phpnode
Copy link
Contributor

phpnode commented Jan 27, 2017

Should NumericLiteralTypeAnnotation also become NumberLiteralTypeAnnotation in line with Flow?

@danez
Copy link
Member Author

danez commented Jan 27, 2017 •
edited
Loading

@phpnode Nice catch, yes we should do it. Do you want to make a PR based on the 7.0 branch? Otherwise I create an issue.

@koba04
Copy link
Contributor

koba04 commented Jan 27, 2017

If nobody doesn't take that, I can take it.

@danez danez closed this as completed Jan 27, 2017
@danwang danwang mentioned this issue Feb 12, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue help wanted i: bug Tag: Breaking Change
Projects
None yet
Milestone
7.0.0
Development

No branches or pull requests
5 participants
@existentialism @danez @koba04 @AvraamMavridis @phpnode