Skip to content

Remove jsonCompatibleStrings option #9958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolo-ribaudo merged 1 commit into from
Feb 17, 2020
Merged

Remove jsonCompatibleStrings option #9958

nicolo-ribaudo merged 1 commit into from
Feb 17, 2020

Conversation

@tanhauhau
Copy link
Member

@tanhauhau tanhauhau commented May 8, 2019

Q                       A
Fixed Issues? Fixes #9943
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

babel-bot commented May 8, 2019

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10773/

@nicolo-ribaudo nicolo-ribaudo added this to the Babel 8.x milestone May 8, 2019
@nicolo-ribaudo nicolo-ribaudo added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label May 8, 2019
@nicolo-ribaudo
Copy link
Member

nicolo-ribaudo commented May 8, 2019

Thank you! I'm deferring this until Babel 8, since it is a breaking change.

@JLHwung
Copy link
Contributor

JLHwung commented Oct 23, 2019

Could you also submit a PR on babel/website to remove jsonCompatibleStrings on https://babeljs.io/docs/en/babel-generator#options?

@nicolo-ribaudo nicolo-ribaudo mentioned this pull request Nov 21, 2019
Open
34 tasks
@JLHwung JLHwung mentioned this pull request Jan 17, 2020
Merged
@nicolo-ribaudo nicolo-ribaudo changed the base branch from master to next-8-dev February 17, 2020 18:20
@nicolo-ribaudo nicolo-ribaudo changed the title feat: remove jsonCompatibleStrings option Remove jsonCompatibleStrings option Feb 17, 2020
@nicolo-ribaudo nicolo-ribaudo merged commit 7e73998 into babel:next-8-dev Feb 17, 2020
nicolo-ribaudo pushed a commit that referenced this pull request Feb 20, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
ac9a919
nicolo-ribaudo pushed a commit that referenced this pull request Feb 23, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
1d6503c
nicolo-ribaudo pushed a commit that referenced this pull request Feb 27, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
929b85d
nicolo-ribaudo pushed a commit that referenced this pull request Mar 3, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
7601631
nicolo-ribaudo pushed a commit that referenced this pull request Mar 10, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
6d7381c
nicolo-ribaudo pushed a commit that referenced this pull request Mar 11, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
12d43d4
nicolo-ribaudo pushed a commit that referenced this pull request Mar 13, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
826f8dd
nicolo-ribaudo pushed a commit that referenced this pull request Mar 22, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
239285c
nicolo-ribaudo pushed a commit that referenced this pull request Mar 22, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
3383816
This was referenced Apr 11, 2020
Merged
Closed
nicolo-ribaudo pushed a commit that referenced this pull request Apr 11, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
053dece
nicolo-ribaudo pushed a commit that referenced this pull request Apr 11, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
b66191d
nicolo-ribaudo pushed a commit that referenced this pull request Apr 20, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
78e33a6
arku pushed a commit to arku/babel that referenced this pull request Apr 20, 2020
@tanhauhau @arku
Remove jsonCompatibleStrings option (babel#9958)
1591d50
nicolo-ribaudo pushed a commit that referenced this pull request Apr 21, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
f7c035e
nicolo-ribaudo pushed a commit that referenced this pull request Apr 21, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
2594546
nicolo-ribaudo pushed a commit that referenced this pull request Apr 21, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
f7ed8e5
nicolo-ribaudo pushed a commit that referenced this pull request Apr 22, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
39bf0f8
nicolo-ribaudo pushed a commit that referenced this pull request May 8, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
43e5379
nicolo-ribaudo pushed a commit that referenced this pull request May 9, 2020
@tanhauhau @nicolo-ribaudo
Remove jsonCompatibleStrings option (#9958)
874909e
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label May 19, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 19, 2020
@JLHwung JLHwung removed this from the v8.0.0 milestone Aug 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@kaicataldo kaicataldo kaicataldo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release PR: Needs Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Remove jsonCompatibleStrings @babel/generator option

5 participants

@tanhauhau @babel-bot @nicolo-ribaudo @JLHwung @kaicataldo