Skip to content

Only allow Identifiers, Patterns and Rest in parameters of FunctionDeclarations #9488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolo-ribaudo merged 1 commit into from
Feb 15, 2019
Merged

Only allow Identifiers, Patterns and Rest in parameters of FunctionDeclarations #9488

nicolo-ribaudo merged 1 commit into from
Feb 15, 2019

Conversation

@danez
Copy link
Member

@danez danez commented Feb 10, 2019

Q                       A
Fixed Issues? Fixes #4059
Patch: Bug Fix? y
Major: Breaking Change? n
Minor: New Feature? n
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@danez danez added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: types labels Feb 10, 2019
@babel-bot
Copy link
Collaborator

babel-bot commented Feb 10, 2019 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10036/

nicolo-ribaudo
nicolo-ribaudo reviewed Feb 10, 2019
View reviewed changes
packages/babel-types/src/definitions/core.js Outdated
validate: chain(
assertValueType("array"),
assertEach(assertNodeType("LVal")),
assertEach(assertNodeType("Identifier", "Pattern", "RestElement")),
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo Feb 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also TSParameterProperty?

Copy link
Member Author

@danez danez Feb 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@nicolo-ribaudo nicolo-ribaudo merged commit 0f685d9 into babel:master Feb 15, 2019
@danez danez deleted the fix-4059 branch February 26, 2019 20:34
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: types PR: Bug Fix 🐛 A type of pull request used for our changelog categories

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AST seems to allow MemberExpression in function parameter list (T7068)

4 participants

@danez @babel-bot @existentialism @nicolo-ribaudo