Added ability to whitelist specific property/function names to use loose mode when transforming destructuring #9486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/10148/ |
…ose mode when transforming destructuring
… option used and function is not on the list
|
Have updated based on rubber ducking here: facebook/create-react-app#5997 (comment) |
1 task
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
selectiveLooseoption forbabel-plugin-transform-destructuringI've added an extra option called
selectiveLoosetobabel-plugin-transform-destructuringwhich can accept an array of strings which represent property or function names to destructure from. Instead of having a globalloosemode,selectiveLooseallows a user to target specific property/function names.This was a solution based on a specification by @gaearon, further elucidated by this PR by @eivind88 and comment by @Pajn.