Skip to content

Preserve 'false'-options for disabled plugins/presets.#8474

Merged
loganfsmyth merged 1 commit intobabel:masterfrom
loganfsmyth:plugin-opts-preserve-false
Aug 19, 2018
Merged

Preserve 'false'-options for disabled plugins/presets.#8474
loganfsmyth merged 1 commit intobabel:masterfrom
loganfsmyth:plugin-opts-preserve-false

Conversation

@loganfsmyth
Copy link
Copy Markdown
Member

Q                       A
Fixed Issues? Fixes #7920
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This moves the check for options === false into the overall config unification, instead of having it be part of loadPartialConfig.

@loganfsmyth loganfsmyth added the PR: New Feature 🚀 A type of pull request used for our changelog categories label Aug 15, 2018
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Aug 15, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8828/

@loganfsmyth loganfsmyth force-pushed the plugin-opts-preserve-false branch from 79e3899 to a5413bf Compare August 16, 2018 22:41
@loganfsmyth loganfsmyth merged commit ca639b4 into babel:master Aug 19, 2018
@loganfsmyth loganfsmyth deleted the plugin-opts-preserve-false branch August 19, 2018 23:22
@lock lock Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve disabled plugins / presets in @babel/core loadPartialConfig()

2 participants