Allow babel-plugin/preset prefix to not be a prefix, when used in a scope.#8473
Merged
loganfsmyth merged 1 commit intobabel:masterfrom Aug 16, 2018
Merged
Conversation
…when used in a scope.
loganfsmyth
added
PR: Breaking Change 💥
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8817/ |
existentialism
approved these changes
Aug 15, 2018
nicolo-ribaudo
approved these changes
Aug 15, 2018
hzoo
approved these changes
Aug 15, 2018
Closed
lock
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In 7.x, in the top-level npm registry scope, we require "babel-plugin-" or "babel-preset-" to be a prefix on plugins/preset names, and if it is not detected, we auto-insert it at the beginning of the package name. Similarly, we auto-inject that prefix for packages used in a scope too, e.g.
@foo/somethingwill become@foo/babel-plugin-something.What this PR does is make it so that, if there is a scope and "babel-plugin" is anywhere in the package name (after the scope name anyway), we will skip inserting the prefix. See #8236 for an example usecase.