Skip to content

Remove File#resolveModuleSource#8470

Merged
loganfsmyth merged 1 commit intobabel:masterfrom
nicolo-ribaudo:remove-resolveModuleSource
Aug 20, 2018
Merged

Remove File#resolveModuleSource#8470
loganfsmyth merged 1 commit intobabel:masterfrom
nicolo-ribaudo:remove-resolveModuleSource

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change? yes
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

It was "disabled" in #6343.

resolveModuleSource which ran on ES6 imports only (unless my remove babel-helper-module-imports addition) and kind of useless anyway because it never runs on require() calls.

@nicolo-ribaudo nicolo-ribaudo added the PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release label Aug 14, 2018
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8811/

1 similar comment
@babel-bot
Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8811/

@loganfsmyth loganfsmyth merged commit f8b0a55 into babel:master Aug 20, 2018
@nicolo-ribaudo nicolo-ribaudo deleted the remove-resolveModuleSource branch August 20, 2018 19:22
@lock lock Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants