Skip to content

TypeScript: Support type arguments on JSX opening and self-closing tags#7799

Merged
existentialism merged 3 commits intomasterfrom
unknown repository
Jul 10, 2018
Merged

TypeScript: Support type arguments on JSX opening and self-closing tags#7799
existentialism merged 3 commits intomasterfrom
unknown repository

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 24, 2018

Q                       A
Fixed Issues? Fixes #7748
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR
Any Dependency Changes?
License MIT

@JamesHenry This changes the AST format. CC @DanielRosenwasser for review.
Supports parsing type arguments on JSX constructors, originally implemented in microsoft/TypeScript#22415.

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Apr 24, 2018

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/8570/

@existentialism existentialism added area: typescript PR: New Feature 🚀 A type of pull request used for our changelog categories labels Apr 25, 2018
Copy link
Copy Markdown
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you rebase this PR?

@existentialism
Copy link
Copy Markdown
Member

existentialism commented Jul 10, 2018

Rebased and fixed up a test, will land after CI!

@existentialism existentialism merged commit 301db1b into babel:master Jul 10, 2018
@ghost ghost deleted the jsxConstructorTypeArguments branch July 11, 2018 00:19
mAAdhaTTah added a commit to valtech-nyc/babel that referenced this pull request Jul 22, 2018
* master:
  remove .then from dynamic import parser exception message (babel#8355)
  update jest (major), babel-jest (major) (babel#8341)
  update prettier (babel#8339)
  bump flow (babel#8338)
  updates eslint, babel-eslint, eslint-plugin-flowtype, eslint-plugin-prettier (babel#8337)
  update changelog for .53/.54 [skip ci]
  v7.0.0-beta.54
  also default stage 2 to decoratorsLegacy true [skip ci]
  Fix stage-0/1 import of pipeline/decorators proposals (babel#8317)
  Remove micromatch and use a simple pattern matching utility.
  Ensure that the wildcard interop is used with re-export + default. (babel#8316)
  Leave it to users to clear the require cache if they want to.
  Remove dependency on barely-used package.
  Add link to audio version of song (babel#8320)
  Remove option-filtering options from the final options results. (babel#8315)
  Update pirates to 4.0 (babel#8308)
  remove yearly preset folders [skip ci]
  v7.0.0-beta.53
  Make env preset build-data scripts reproducible (babel#8299)
  TypeScript: Support type arguments on JSX opening and self-closing tags (babel#7799)
storyn26383 pushed a commit to UniSharp/babel that referenced this pull request Aug 6, 2018
@lock lock Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 4, 2019
@lock lock Bot locked as resolved and limited conversation to collaborators Oct 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: New Feature 🚀 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TypeScript type arguments on JSX tags

5 participants