TypeScript: Support conditional types syntax #7404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
PR: New Feature 🚀
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/6919/ |
j-f1
reviewed
Feb 20, 2018
| @@ -1875,6 +1875,22 @@ Aliases: `TSTypeElement` | |||
|
|
|||
| --- | |||
|
|
|||
| ### tSConditionalType | |||
There was a problem hiding this comment.
It's generated, and should get fixed after we land: #6993
There was a problem hiding this comment.
I'm cool with landing it, we can first make a change to https://github.com/babel/babel-upgrade for it pretty easily
|
Thanks for the heads up, @Andy-MS! This is really cool |
existentialism
approved these changes
Feb 23, 2018
xtuc
approved these changes
Feb 23, 2018
JamesHenry
approved these changes
Feb 23, 2018
DanielRosenwasser
approved these changes
Feb 24, 2018
DanielRosenwasser
approved these changes
Feb 24, 2018
3 tasks
|
Thank you! |
benjamn
added a commit
to benjamn/ast-types
that referenced
this pull request
Feb 24, 2018
benjamn
added a commit
to benjamn/recast
that referenced
this pull request
Feb 24, 2018
Although (infer T) must frequently be parenthesized to avoid ambiguity, Recast does not have to encode that logic into FastPath#needsParens, because Babylon wraps such types with TSParenthesizedType. Cool! babel/babel#7404 benjamn/ast-types@da0367b microsoft/TypeScript#21316 microsoft/TypeScript#21496
|
Working in |
ghost
deleted the
This was referenced Mar 14, 2018
Closed
aminmarashi
pushed a commit
to aminmarashi/babel
that referenced
this pull request
Mar 17, 2018
benjamn
added a commit
to benjamn/babel
that referenced
this pull request
May 18, 2018
Follow-up to babel#7404 There is no TypeParameter type in the Babylon TypeScript AST hierarchy. Flow does have a TypeParameter type, but it should not be confused with the TypeScript TSTypeParameter, since Flow !== TypeScript, and the types have totally different fields. Instead, the .typeParameter.type of a Babylon-parsed TSInferType node should be TSTypeParameter. It would probably be fine to leave the declared type of the TSInferType .typeParameter field as TSType instead of TSTypeParameter, but the more specific TSTypeParameter type should be safe/correct, since the TypeScript parseInferType function always uses SyntaxKind.TypeParameter: https://github.com/Microsoft/TypeScript/blob/66d6e5e6e007ce3ac70b7371c3e7ac46a99a0fcd/src/compiler/parser.ts#L3006 I noticed this typo because it has been causing ast-types test failures lately, e.g. https://travis-ci.org/benjamn/ast-types/jobs/369634972
existentialism
pushed a commit
that referenced
this pull request
May 18, 2018
Follow-up to #7404 There is no TypeParameter type in the Babylon TypeScript AST hierarchy. Flow does have a TypeParameter type, but it should not be confused with the TypeScript TSTypeParameter, since Flow !== TypeScript, and the types have totally different fields. Instead, the .typeParameter.type of a Babylon-parsed TSInferType node should be TSTypeParameter. It would probably be fine to leave the declared type of the TSInferType .typeParameter field as TSType instead of TSTypeParameter, but the more specific TSTypeParameter type should be safe/correct, since the TypeScript parseInferType function always uses SyntaxKind.TypeParameter: https://github.com/Microsoft/TypeScript/blob/66d6e5e6e007ce3ac70b7371c3e7ac46a99a0fcd/src/compiler/parser.ts#L3006 I noticed this typo because it has been causing ast-types test failures lately, e.g. https://travis-ci.org/benjamn/ast-types/jobs/369634972
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JamesHenry This changes the AST format. CC @DanielRosenwasser for review.
Supports the syntax from microsoft/TypeScript#21316 and microsoft/TypeScript#21496. Now you can write
type Element<T> = T extends (infer U)[] ? U : T;.