Merged
Conversation
motiz88
added
area: tests
PR: Internal 🏠
Current coverage is 89.37% (diff: 100%)@@ master #4742 diff @@
==========================================
Files 196 196
Lines 13884 13887 +3
Methods 1434 1434
Messages 0 0
Branches 3198 3198
==========================================
+ Hits 12333 12412 +79
+ Misses 1551 1475 -76
Partials 0 0
|
hzoo
reviewed
Oct 18, 2016
|
|
||
| export { Func as Function, Func as Class }; | ||
| export { | ||
| Func as FunctionExpression, |
Member
There was a problem hiding this comment.
Would this be breaking if we remove Func as Function, Func as Class? (although maybe it's not used at all)
Contributor
Author
There was a problem hiding this comment.
I interpreted it to be an implementation detail, where getTypeAnnotation(), baseTypeStrictlyMatches() etc are the actual API.
Contributor
Author
There was a problem hiding this comment.
And IIRC this was actually broken the old way - i.e. whoever wrote this was clearly expecting some code to expand Function and Class a la visitor method names, and it wasn't happening. (But not tested so it only came up when I tackled coverage)
Member
There was a problem hiding this comment.
👍 yeah we have a lot that might not be used anywhere
hzoo
approved these changes
Oct 18, 2016
Member
|
Awesome. |
mstade
added a commit
to zambezi/babel
that referenced
this pull request
Oct 28, 2016
* master: (38 commits) chore(package): update browserify to version 13.1.1 (babel#4762) Increase test coverage (babel#4742) Make getBinding ignore labels; add Scope#getLabel, Scope#registerLabel (babel#4758) Add variance node type and generate property variance annotations (babel#4697) Add make command to delete node_modules (babel#4748) fixes [skip ci] Support ObjectExpression in static path evaluation (babel#4746) Fix replacing for-of if inside label (babel#4736) Replace `path-exists` with `fs.existsSync` (babel#4731) Avoid unnecessary +0 in transform-es2015-parameters (babel#4738) [import()] Initial support for dynamic-import (babel#4699) Fix line endings on checkout Automatically generate missing expected.js fixtures (babel#4735) Fix few typos in issue/pr templates (babel#4739) [skip ci] contributing updates [skip ci] increase git depth [skip ci] Change usage of "suite"/"test" in unit-tests to "describe"/"it" (babel#4734) Run ESLint on test files, and fix lint errors in test files (babel#4732) Add .gitattributes forcing LF line endings (babel#4730) Update tests for changed error messages in Babylon (babel#4727) ...
panagosg7
pushed a commit
to panagosg7/babel
that referenced
this pull request
Jan 17, 2017
* Add tests for path type inferers * Add test for babel-types.valueToNode * Add tests for babel-types.toKeyAlias * Add tests for babel-types.toStatement * Add tests for babel-types.toExpression * Lint fixes in babel-traverse/test/inference
lock
bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In much the same vein as babel/babylon#175 - this is the first batch of new tests written explicitly to hit previously uncovered lines/branches. I'll be adding more, but they are all independent of one another, so if anyone wants to take time to review & merge some snapshot of this branch - just let me know and I'll move to another one.