Skip to content

[RFC] Make getBinding ignore labels; add Scope#getLabel#3649

Closed
kangax wants to merge 1 commit intobabel:masterfrom
kangax:master
Closed

[RFC] Make getBinding ignore labels; add Scope#getLabel#3649
kangax wants to merge 1 commit intobabel:masterfrom
kangax:master

Conversation

@kangax
Copy link
Copy Markdown
Member

@kangax kangax commented Aug 10, 2016

Fixes #3978

@sebmck
Copy link
Copy Markdown
Contributor

sebmck commented Aug 20, 2016

uid generator needs to be aware of these so collisions aren't generated.

@hzoo
Copy link
Copy Markdown
Member

hzoo commented Aug 20, 2016

@kittens ah good catch, would we create a hasLabel/hasLabelBinding and add it to the generateUid check in https://github.com/babel/babel/blob/master/packages/babel-traverse/src/scope/index.js#L220?

@kangax kangax closed this Oct 20, 2016
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Labels shadow bindings (T6957)

3 participants