Catchup source map position in preserveFormat#18011
Merged
nicolo-ribaudo merged 2 commits intoMay 25, 2026
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61605 |
|
commit: |
f8b1470 to
da9d00c
Compare
JLHwung
approved these changes
May 22, 2026
liuxingbaoyu
approved these changes
May 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2Consider the case where we strip types from
var x: number = 1in preserve format mode. Whenever we print a node, the generator automatically keeps the original source position up to date with the original node position.This means that we would print the
Identifier("x"), and then set the original source position to the space afternumber(because: numberis part of the identifier node). Then, when printing=, we'd first print the necessary spaces to catch up with the correct location (). Before doing that,.append()would insert a mapping, thus mapping the space right afterxin the generated code to the one right afternumberin the original code.This PR changes two things:
sourcePositionto actually point to where we catched up to thanks to the spacesThis change helps shaving multiple KBs off from the
preserveFormattest cases in #18006, but it's also a correctness fix on its own.