refactor(ESM): convert babel-eslint-plugin and babel-register#17943
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61331 |
JLHwung
commented
Apr 21, 2026
| }); | ||
|
|
||
| test("installs source map support when requested", () => { | ||
| test.skip("installs source map support when requested", () => { |
Contributor
Author
There was a problem hiding this comment.
This test is failing because the teardown step delete require.cache[registerFile]; no longer work for ESM, therefore any subsequent test becomes reentry to the index file and thus the installSourceMapSupport is always a no-op after it is installed:
babel/packages/babel-register/src/hook.cts
Lines 8 to 25 in 5d39158
This issue will be fixed by #17941.
Contributor
Author
Merged
|
commit: |
JLHwung
commented
Apr 21, 2026
| const ruleComposer = require("../rule-composer.cjs"); | ||
| const rule = require("eslint/use-at-your-own-risk").builtinRules.get("new-cap"); | ||
| import * as ruleComposer from "../rule-composer.js"; | ||
| // eslint-disable-next-line import/no-unresolved |
Contributor
Author
There was a problem hiding this comment.
Disabled due to an upstream issue: import-js/eslint-plugin-import#1810.
liuxingbaoyu
approved these changes
Apr 22, 2026
nicolo-ribaudo
approved these changes
Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we converted babel-eslint-plugin and babel-register to ESM, thanks to the
require(esm)supported in Node.js.Only one failingbabel-registertest is disabled, see comments below.