Remove @babel/plugin-transform-property-mutators#17882
Conversation
liuxingbaoyu
added
PR: Breaking Change 💥
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61207 |
|
commit: |
There was a problem hiding this comment.
This plugin debuted in 6.0.0 as babel-plugin-transform-es5-property-mutators.
I guess the intention of this plugin is to transform the ES5 get/set to ES3, with the merely hope that Object.defineProperties, when polyfilled by core-js, can run on ES3 environments, such that get/set does not produce a syntax error. But unfortunately there is no magic to polyfill getter/setter on IE8, core-js just throws a better error when { get: function() {} } is passed.
Therefore this plugin is not really very helpful and maybe that's why it is not included in the preset-env, I agree that we should remove this plugin from Babel 8.
With that said, could you also open a PR to the babel-archive repo?
|
Merging, but please submit the docs PR and add it to the archive! |
4 participants
Fixes #1, Fixes #2It converts
{get x(){}}toObject.defineProperties, butgetwas supported by browsers earlier.