Fix(parser): async x => {} must be in leading pos#17839
Merged
JLHwung merged 2 commits intobabel:mainfrom Feb 27, 2026
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61063 |
nicolo-ribaudo
approved these changes
Feb 27, 2026
liuxingbaoyu
approved these changes
Feb 27, 2026
Member
liuxingbaoyu
left a comment
There was a problem hiding this comment.
I'm surprised we passed all the test262 syntax tests in the past. :)
|
commit: |
Contributor
Author
|
Yeah, apparently |
Member
|
No problem, this shouldn't affect anyone. :) |
2d9cea7 to
caa406b
Compare
caa406b to
1f6c840
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we forbid the single name async arrow, e.g.
async x => {}forming in the unary argument, binary expression, class heritage and legacy decorators. Previously such productions were accepted by the parser but they are not allowed in the spec.