Enable strictNullChecks for create-class-features-plugin#17824
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61005 |
|
commit: |
| }, | ||
|
|
||
| ...namedEvaluationVisitor, | ||
| ...(namedEvaluationVisitor as any), |
There was a problem hiding this comment.
Could we avoid the any cast here?
There was a problem hiding this comment.
Making VisitorBase public might be helpful.
There was a problem hiding this comment.
I tried it, and import("../../babel-traverse/src/types.ts").VisitorBase worked.
Do we need to export it? We must also re-export it in @babel/core because we don't have a direct dependency on @babel/traverse.
There was a problem hiding this comment.
I am good for exporting it.
There was a problem hiding this comment.
Oh, we've already exported it. We just need to reexport it. :)
| this.receiver(member), | ||
| ]); | ||
|
|
||
| return t.callExpression(file.addHelper("classPrivateFieldGet"), [ |
There was a problem hiding this comment.
Do we currently have eslint rule to detect unreachable return?
There was a problem hiding this comment.
I will open a new PR to handle it.
|
The CI failure was unrelated to the PR, the latest version of Node.js broke yargs' compatibility. |
70fab0f to
f827366
Compare
github-actions
Bot
added
the
outdated
4 participants
Fixes #1, Fixes #2