Improve F# pipeline direct body check#17806
Merged
nicolo-ribaudo merged 6 commits intobabel:mainfrom Feb 27, 2026
Merged
Conversation
JLHwung
added
PR: Bug Fix 🐛
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/61021 |
JLHwung
force-pushed
the
improve-fsharp-direct-body-check
branch
from
c302c89 to
72bfeee
Compare
|
commit: |
JLHwung
added
PR: Bug Fix (next major) 🐛
JLHwung
force-pushed
the
improve-fsharp-direct-body-check
branch
from
3dcf4c5 to
d2c784c
Compare
JLHwung
force-pushed
the
improve-fsharp-direct-body-check
branch
from
468cda1 to
c625231
Compare
nicolo-ribaudo
added
the
PR: Bug Fix 🐛
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains commits from #17803. Please review that PR first.Previously we used a tokenizer state
inFSharpPipelineDirectBodyto track whether|>is seen within the direct body of an F# pipeline. The state is reset when we are parsing parenthesis / arrow, call arguments / async arrow, array and object literal.The reset is not complete as it does not cover the following cases: block statement, function body, parameter initializer, computed property, template quasis, static block, etc. All of them can host AssignmentExpression, and thus can host a new pipeline expression. But because the state is not reset, the parser will stop at the
|>, resulting to unexpected parsing errors.In this PR we track the FSharpPiplelineBody in the production parameter handler. A
PARAM_NOT_FSHARP_PIPELINE_DIRECT_BODYparameter is introduced and associated with most parameter scopes: Specifically, this parameter is enabled when we parse anAssignmentExpression[+In],AssignmentExpression[~In]. TheFSharpPipelineBodyparsing routine disables this flag, and theConciseBodywill inherit this flag from the upper scope.The new approach passes all previous test cases as well as new test cases on which the main is currently failing. We also removed the now unused tokenizer state
inFSharpPipelineDirectBody.