Disallow non-leading solo await within F# pipeline#17803
Merged
JLHwung merged 6 commits intobabel:mainfrom Feb 24, 2026
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60933 |
|
commit: |
eed88c2 to
584c2f8
Compare
liuxingbaoyu
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per proposal spec,
The solo await expression
awaitis only allowed when it is the only production within the pipeline body, there is also a specificawaitlookahead before forming theLogicalORExpression. Previously Babel allowed solo await within the pipeline body even if theawaitexpression might not be the only production. For example, the following cases were accepted by the current Babel parser but forbidden by the proposal spec:The new approach only allows forming AwaitExpression when it see
awaitafter the pipeline operator.We also banned binary operator after solo await as the
LogicalORExpressioncan not coverPipelineExpression, users should parenthesize the complete solo-await pipeline if it is used with a binary operator.