cleanup @ts-expect-error(Babel 7 vs Babel 8) comments (Part 1)#17651
Merged
JLHwung merged 4 commits intobabel:mainfrom Dec 12, 2025
Merged
cleanup @ts-expect-error(Babel 7 vs Babel 8) comments (Part 1)#17651JLHwung merged 4 commits intobabel:mainfrom
@ts-expect-error(Babel 7 vs Babel 8) comments (Part 1)#17651JLHwung merged 4 commits intobabel:mainfrom
Conversation
JLHwung
added
the
PR: Internal (next major) 🏠
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60430 |
|
commit: |
JLHwung
force-pushed
the
cleanup-ts-expect-error
branch
from
915d25f to
a04e841
Compare
nicolo-ribaudo
approved these changes
Dec 12, 2025
liuxingbaoyu
approved these changes
Dec 12, 2025
github-actions
bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ts-expect-errorcommentsThis PR cleans up a few
@ts-expect-errorcomments introduced when we materialize the Babel 8 breaking flag.There are still a few
@ts-expect-errorcomments left in current codebase. They are due to the following typing changes from 7 to 8:Superis extracted fromExpression, but we tried to createSuperas an LHSVoidPatternis a valididof the variable declarator, but we tried to createVoidPatternas an LHSThese typing errors are legitimate errors that we should handle, either by improving the transform logic or throwing a better error that we do not support certain
superproductions. Anyway I think they'd be better addressed in another PR.