Merged
Conversation
This refactor also removes the dependency to the glob library. Previously we have to pin glob to 7.2.0 because the test should run on node.js 6.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60178 |
|
commit: |
|
@JLHwung release? |
nicolo-ribaudo
approved these changes
Nov 20, 2025
liuxingbaoyu
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we bump glob to v12 for Babel 8. The only breaking change between glob v11 and v12 is the removal of the
--shelloption which we do not depend on.This PR also refactors the babel-types/test/fields test such that the test does not depend on the
globpackage anymore. The refactor also simplifies the fixture-related handling logic.Please turn off the whitespace chagnes when reviewing the last commit.