Skip to content

Fully remove Records and Tuples support#17528

Merged
nicolo-ribaudo merged 10 commits intobabel:mainfrom
nicolo-ribaudo:fix-types-87
Oct 23, 2025
Merged

Fully remove Records and Tuples support#17528
nicolo-ribaudo merged 10 commits intobabel:mainfrom
nicolo-ribaudo:fix-types-87

Conversation

@nicolo-ribaudo
Copy link
Copy Markdown
Member

Q                       A
Fixed Issues? Fixes #17524
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added babel 8 PR: Bug Fix (next major) 🐛 A type of pull request used for our changelog categories for next major release and removed babel 8 labels Sep 26, 2025
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Sep 26, 2025

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60073

JLHwung
JLHwung previously approved these changes Sep 26, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Sep 26, 2025

Open in StackBlitz

commit: b35ebef

@nicolo-ribaudo nicolo-ribaudo changed the title Remove TupleExpression and RecordExpression from @babel/types Fully remove Records and Tuples support Oct 3, 2025
@nicolo-ribaudo nicolo-ribaudo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed PR: Bug Fix (next major) 🐛 A type of pull request used for our changelog categories for next major release labels Oct 3, 2025
@fisker
Copy link
Copy Markdown
Contributor

fisker commented Oct 10, 2025

@nicolo-ribaudo

I just added some checks for VisitorKeys in Prettier, which may cause the Prettier E2E test to fail from this line.

Removing TupleExpression and RecordExpression from here https://github.com/prettier/prettier/blob/fbcdccbf270fad54773f4a8a99714549a771074a/src/language-js/traverse/visitor-keys.evaluate.js#L54-L55 should make the test pass.

Please rerun.

@nicolo-ribaudo nicolo-ribaudo merged commit dfce3d6 into babel:main Oct 23, 2025
82 of 83 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the fix-types-87 branch October 23, 2025 15:53
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 23, 2026
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v8] VISITOR_KEYS contains removed node type

5 participants