Skip to content

Conversation

@JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 27, 2025

Q                       A
Fixed Issues? The e2e Babel old version CI is breaking because the snapshot guide link is outdated: https://github.com/babel/babel/actions/runs/17273609906/job/49025252683?pr=17491
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In jestjs/jest#15787, Jest updated the snapshot guide link and will throw as error when the snapshot link is the legacy one. Previously the snapshot guide link is not checked so updating those links should be okay for older Jest versions, used in our Node.js 6 test.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59873

@pkg-pr-new
Copy link

pkg-pr-new bot commented Aug 27, 2025

Open in StackBlitz

commit: 4265f1b

Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a breaking change as it will break CI which is green.

@JLHwung JLHwung merged commit b41f8cd into babel:main Aug 27, 2025
76 checks passed
@JLHwung JLHwung deleted the update-jest branch August 27, 2025 18:14
@JLHwung
Copy link
Contributor Author

JLHwung commented Aug 27, 2025

This seems to be a breaking change as it will break CI which is green.

Yeah, it's a small breaking change but fortunately the migration can be done automatically so no complaints.

@JLHwung JLHwung added the PR: Internal 🏠 A type of pull request used for our changelog categories label Aug 27, 2025
BugBareDrums added a commit to DEFRA/grants-ui that referenced this pull request Sep 29, 2025
![snyk-top-banner](https://res.cloudinary.com/snyk/image/upload/r-d/scm-platform/snyk-pull-requests/pr-banner-default.svg)


<h3>Snyk has created this PR to upgrade @babel/runtime from 7.28.3 to
7.28.4.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.

<hr/>


- The recommended version is **1 version** ahead of your current
version.

- The recommended version was released **22 days ago**.



<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>@babel/runtime</b></summary>
    <ul>
      <li>
<b>7.28.4</b> - <a
href="https://redirect.github.com/babel/babel/releases/tag/v7.28.4">2025-09-05</a></br><h2>v7.28.4
(2025-09-05)</h2>
<p>Thanks <a class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/gwillen/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/gwillen">@ gwillen</a> and <a
class="user-mention notranslate" data-hovercard-type="user"
data-hovercard-url="/users/mrginglymus/hovercard"
data-octo-click="hovercard-link-click"
data-octo-dimensions="link_type:self"
href="https://redirect.github.com/mrginglymus">@ mrginglymus</a> for
your first PRs!</p>
<h4>🏠 Internal</h4>
<ul>
<li><code>babel-core</code>,
<code>babel-helper-check-duplicate-nodes</code>,
<code>babel-traverse</code>, <code>babel-types</code>
<ul>
<li><a href="https://redirect.github.com/babel/babel/pull/17493"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17493/hovercard">#17493</a> Update
Jest to v30.1.1 (<a href="https://redirect.github.com/JLHwung">@
JLHwung</a>)</li>
</ul>
</li>
<li><code>babel-plugin-transform-regenerator</code>
<ul>
<li><a href="https://redirect.github.com/babel/babel/pull/17455"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17455/hovercard">#17455</a> chore:
Clean up <code>transform-regenerator</code> (<a
href="https://redirect.github.com/liuxingbaoyu">@ liuxingbaoyu</a>)</li>
</ul>
</li>
<li><code>babel-core</code>
<ul>
<li><a href="https://redirect.github.com/babel/babel/pull/17474"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17474/hovercard">#17474</a> Switch
to @ jridgewell/remapping (<a
href="https://redirect.github.com/mrginglymus">@ mrginglymus</a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 5</h4>
<ul>
<li>Babel Bot (<a href="https://redirect.github.com/babel-bot">@
babel-bot</a>)</li>
<li>Bill Collins (<a href="https://redirect.github.com/mrginglymus">@
mrginglymus</a>)</li>
<li>Glenn Willen (<a href="https://redirect.github.com/gwillen">@
gwillen</a>)</li>
<li>Huáng Jùnliàng (<a href="https://redirect.github.com/JLHwung">@
JLHwung</a>)</li>
<li><a href="https://redirect.github.com/liuxingbaoyu">@
liuxingbaoyu</a></li>
</ul>
      </li>
      <li>
<b>7.28.3</b> - <a
href="https://redirect.github.com/babel/babel/releases/tag/v7.28.3">2025-08-14</a></br><h2>v7.28.3
(2025-08-14)</h2>
<h4>👓 Spec Compliance</h4>
<ul>
<li><code>babel-helper-create-class-features-plugin</code>,
<code>babel-plugin-proposal-decorators</code>,
<code>babel-plugin-transform-class-static-block</code>,
<code>babel-preset-env</code>
<ul>
<li><a href="https://redirect.github.com/babel/babel/pull/17443"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17443/hovercard">#17443</a>
[static blocks] Do not inject new static fields after static code (<a
href="https://redirect.github.com/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>🐛 Bug Fix</h4>
<ul>
<li><code>babel-parser</code>
<ul>
<li><a href="https://redirect.github.com/babel/babel/pull/17465"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17465/hovercard">#17465</a>
fix(parser/typescript): parse <code>import("./a", {with:{},})</code> (<a
href="https://redirect.github.com/easrng">@ easrng</a>)</li>
<li><a href="https://redirect.github.com/babel/babel/pull/17478"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17478/hovercard">#17478</a>
fix(parser): stop subscript parsing on async arrow (<a
href="https://redirect.github.com/JLHwung">@ JLHwung</a>)</li>
</ul>
</li>
</ul>
<h4>💅 Polish</h4>
<ul>
<li><code>babel-plugin-transform-regenerator</code>,
<code>babel-plugin-transform-runtime</code>
<ul>
<li><a href="https://redirect.github.com/babel/babel/pull/17363"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17363/hovercard">#17363</a> Do not
save last yield in call in temp var (<a
href="https://redirect.github.com/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
</ul>
</li>
</ul>
<h4>📝 Documentation</h4>
<ul>
<li><a href="https://redirect.github.com/babel/babel/pull/17448"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17448/hovercard">#17448</a> move
eslint-{parser,plugin} docs to the website (<a
href="https://redirect.github.com/JLHwung">@ JLHwung</a>)</li>
</ul>
<h4>🏠 Internal</h4>
<ul>
<li><a href="https://redirect.github.com/babel/babel/pull/17454"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17454/hovercard">#17454</a> Enable
type checking for <code>scripts</code> and <code>babel-worker.cjs</code>
(<a href="https://redirect.github.com/JLHwung">@ JLHwung</a>)</li>
</ul>
<h4>🔬 Output optimization</h4>
<ul>
<li><code>babel-plugin-proposal-destructuring-private</code>,
<code>babel-plugin-proposal-do-expressions</code>
<ul>
<li><a href="https://redirect.github.com/babel/babel/pull/17444"
data-hovercard-type="pull_request"
data-hovercard-url="/babel/babel/pull/17444/hovercard">#17444</a>
Optimize do expression output (<a
href="https://redirect.github.com/JLHwung">@ JLHwung</a>)</li>
</ul>
</li>
</ul>
<h4>Committers: 5</h4>
<ul>
<li>Babel Bot (<a href="https://redirect.github.com/babel-bot">@
babel-bot</a>)</li>
<li>Huáng Jùnliàng (<a href="https://redirect.github.com/JLHwung">@
JLHwung</a>)</li>
<li>Jam Balaya (<a href="https://redirect.github.com/JamBalaya56562">@
JamBalaya56562</a>)</li>
<li>Nicolò Ribaudo (<a
href="https://redirect.github.com/nicolo-ribaudo">@
nicolo-ribaudo</a>)</li>
<li>easrng (<a href="https://redirect.github.com/easrng">@
easrng</a>)</li>
</ul>
      </li>
    </ul>
from <a
href="https://redirect.github.com/babel/babel/releases">@babel/runtime
GitHub release notes</a>
  </details>
</details>

---

> [!IMPORTANT]
>
> - Check the changes in this PR to ensure they won't cause issues with
your project.
> - This PR was automatically created by Snyk using the credentials of a
real user.

---

**Note:** _You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs._

**For more information:** <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiJmOTY5NTNlMS1jOTM2LTRiMDYtOTFkMi1hN2I1YjNjMjMwOTgiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6ImY5Njk1M2UxLWM5MzYtNGIwNi05MWQyLWE3YjViM2MyMzA5OCJ9fQ=="
width="0" height="0"/>

> - 🧐 [View latest project
report](https://app.snyk.io/org/alanplatt/project/ff50773c-5262-40d8-b38d-68f56510f59a?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 📜 [Customise PR
templates](https://docs.snyk.io/scan-using-snyk/pull-requests/snyk-fix-pull-or-merge-requests/customize-pr-templates?utm_source=&utm_content=fix-pr-template)
> - 🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/alanplatt/project/ff50773c-5262-40d8-b38d-68f56510f59a/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)
> - 🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/alanplatt/project/ff50773c-5262-40d8-b38d-68f56510f59a/settings/integration?pkg&#x3D;@babel/runtime&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

[//]: #
'snyk:metadata:{"breakingChangeRiskLevel":null,"FF_showPullRequestBreakingChanges":null,"FF_showPullRequestBreakingChangesWebSearch":null,"customTemplate":{"variablesUsed":[],"fieldsUsed":[]},"dependencies":[{"name":"@babel/runtime","from":"7.28.3","to":"7.28.4"}],"env":"prod","hasFixes":false,"isBreakingChange":false,"isMajorUpgrade":false,"issuesToFix":[],"prId":"f96953e1-c936-4b06-91d2-a7b5b3c23098","prPublicId":"f96953e1-c936-4b06-91d2-a7b5b3c23098","packageManager":"npm","priorityScoreList":[],"projectPublicId":"ff50773c-5262-40d8-b38d-68f56510f59a","projectUrl":"https://app.snyk.io/org/alanplatt/project/ff50773c-5262-40d8-b38d-68f56510f59a?utm_source=github&utm_medium=referral&page=upgrade-pr","prType":"upgrade","templateFieldSources":{"branchName":"default","commitMessage":"default","description":"default","title":"default"},"templateVariants":[],"type":"auto","upgrade":[],"upgradeInfo":{"versionsDiff":1,"publishedDate":"2025-09-05T14:53:08.958Z"},"vulns":[]}'
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 27, 2025
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Dependency ⬆️ PR: Fixes failing main PR: Internal 🏠 A type of pull request used for our changelog categories

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants