Do not enable default plugins in @babel/standalone
#17421
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59702 |
Contributor
Author
|
(The fact that it's 3AM and it took me two force-pushes to get a version of this that I believe is correct suggests I should probably at minimum manually test it tomorrow, if not figure out how to write a test for it, but right now I'm going to sleep.) |
JLHwung
reviewed
Jul 1, 2025
Co-authored-by: Huáng Jùnliàng <[email protected]>
Contributor
Author
|
... failure might be spurious? I can't figure out what's going on in the log there. |
Member
|
Yeah it's not related, I'm restarting that job. |
nicolo-ribaudo
added
the
PR: Breaking Change 💥
nicolo-ribaudo
changed the title
@babel/standalone
JLHwung
approved these changes
Jul 7, 2025
liuxingbaoyu
approved these changes
Aug 20, 2025
1 task
This was referenced Oct 21, 2025
This was referenced Nov 19, 2025
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is per #17419 (comment), but does not fully fix that issue.
As suggested I've made it a future change for Babel 8. I did not add any tests (and I wouldn't really know where to start), but I did run the existing tests for babel-standalone and they continue to pass. (I have no idea whether they even attempt to exercise any of this, though.)
I'm happy to tweak it for any local style things I missed, but I'd just as soon you edit it directly, if it's otherwise suitable.