[Babel 8]: Fix incorrect LVal coverage #17387
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Breaking Change 💥
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/59583 |
nicolo-ribaudo
approved these changes
Jun 16, 2025
JLHwung
force-pushed
the
fix-incorrect-lhs-coverage
branch
from
3c116c5 to
71c0d33
Compare
liuxingbaoyu
approved these changes
Jun 16, 2025
Contributor
Author
|
Docs PR is ready, ptal: babel/website#3103 |
RReverser
reviewed
Jun 18, 2025
|
|
||
| function flattenLVal( | ||
| path: NodePath<t.LVal | t.OptionalMemberExpression>, | ||
| path: NodePath<t.LVal | t.PatternLike | t.OptionalMemberExpression>, |
Member
There was a problem hiding this comment.
OptionalMemberExpression should probably be also an LVal itself just like MemberExpression is, rather than listing it separately?
Contributor
Author
There was a problem hiding this comment.
Yes. That will be a new feature and thus be handled in a new PR. (Breaking changes can be merged directly as long as it's behind the BABEL_8_BREAKING flag but features has to be waited for the next release).
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request we remove
AssignmentPatternandRestElementfrom theLValalias, since they must be nested within a pattern or a function parameter, rather than being allowed to be the LHS of an assignment. The typing usage in the codebase is also updated: we broaden the previoust.LValwitht.PatternLikesuch that it covers those two elements as well.