[Babel 8] Parse TSHeritageBase.expression as an expression#17139
Merged
JLHwung merged 6 commits intobabel:mainfrom Feb 23, 2025
Merged
[Babel 8] Parse TSHeritageBase.expression as an expression#17139JLHwung merged 6 commits intobabel:mainfrom
JLHwung merged 6 commits intobabel:mainfrom
Conversation
JLHwung
added
PR: Breaking Change 💥
11 tasks
JLHwung
commented
Feb 18, 2025
| @@ -0,0 +1,2 @@ | |||
| // Every extend element here is invalid | |||
| interface Invalid extends foo[bar], foo?.bar, foo(), import.meta {} | |||
Contributor
Author
There was a problem hiding this comment.
Unfortunately the last example is currently accepted by Babel 7. In this PR we fix that for Babel 8.
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58749 |
nicolo-ribaudo
approved these changes
Feb 21, 2025
liuxingbaoyu
approved these changes
Feb 22, 2025
JLHwung
commented
Feb 22, 2025
|
|
||
| function tsIsEntityName( | ||
| node: N.Expression, | ||
| ): node is N.MemberExpression | N.Identifier { |
Contributor
Author
There was a problem hiding this comment.
This assertion should be updated.
laine-hallot
pushed a commit
to laine-hallot/uwu-parser
that referenced
this pull request
Mar 31, 2025
github-actions
bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.