[babel 8] Use @babel/types for parser's return type#17117
Merged
nicolo-ribaudo merged 3 commits intobabel:mainfrom Feb 14, 2025
Merged
[babel 8] Use @babel/types for parser's return type#17117nicolo-ribaudo merged 3 commits intobabel:mainfrom
@babel/types for parser's return type#17117nicolo-ribaudo merged 3 commits intobabel:mainfrom
Conversation
nicolo-ribaudo
commented
Feb 7, 2025
| @@ -1,177 +1,24 @@ | |||
| // Type definitions for @babel/parser | |||
Member
Author
There was a problem hiding this comment.
I left this file here to avoid accidental breaking changes, but now it's just re-exporting form the source.
nicolo-ribaudo
force-pushed
the
babel-8-parser-types
branch
from
17d82a2 to
12ab4f0
Compare
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58687 |
nicolo-ribaudo
force-pushed
the
babel-8-parser-types
branch
from
60a0832 to
212c282
Compare
nicolo-ribaudo
commented
Feb 14, 2025
| }; | ||
|
|
||
| export { DecoratorsPluginOptions, FlowPluginOptions, ParseError, ParseResult, ParserOptions, ParserPlugin, ParserPluginWithOptions, PipelineOperatorPluginOptions, RecordAndTuplePluginOptions, TypeScriptPluginOptions, parse, parseExpression, tokTypes }; | ||
| export { DecoratorsPluginOptions, FlowPluginOptions, ParseError, ParseResult, ParserOptions, PluginConfig as ParserPlugin, ParserPluginWithOptions, PipelineOperatorPluginOptions, RecordAndTuplePluginOptions, TypeScriptPluginOptions, parse, parseExpression, tokTypes }; |
Member
Author
There was a problem hiding this comment.
Note: the difference in these two lines is that before it contained , ParserPlugin,, while after it contains , PluginConfig as ParserPlugin,.
Comment on lines
-258
to
-266
| interface ParseError { | ||
| code: string; | ||
| reasonCode: string; | ||
| } | ||
|
|
||
| type ParseResult<Result> = Result & { | ||
| errors: ParseError[]; | ||
| }; | ||
|
|
Member
Author
There was a problem hiding this comment.
These two are just moved above.
| options?: ParserOptions | ||
| ): ParseResult<_babel_types.Expression>; | ||
|
|
||
| interface ParserOptions { |
Member
Author
There was a problem hiding this comment.
This is also just moved above (and renamed, but then the export keeps the old name).
Member
Author
|
I'll merge this, release a new 8.0.0 alpha, play around with it, and see if we are finally ready for the beta :) |
laine-hallot
pushed a commit
to laine-hallot/uwu-parser
that referenced
this pull request
Mar 31, 2025
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Babel 7 we are already using
@babel/typesin@babel/parser/typings/babel-parser.ts. However, Babel 8 usespackage.json#exportsthus that file is ignored.By casting the type to the proper AST types in the
parse()function itself, we can also use the@babel/typesdefinitions in:One day we can actually de-duplicate the definitions, but it's a lot of work and it can wait :)