[Babel 8] Create TSAbstract{Method,Property}Definition#17014
Merged
JLHwung merged 4 commits intobabel:mainfrom Dec 11, 2024
Merged
[Babel 8] Create TSAbstract{Method,Property}Definition#17014JLHwung merged 4 commits intobabel:mainfrom
JLHwung merged 4 commits intobabel:mainfrom
Conversation
JLHwung
added
PR: Breaking Change 💥
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58461 |
11 tasks
Member
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
The changes themselves look good, but is there any reason to not do this inside estree.ts?
Contributor
Author
I don't have strong preference, it should be handled by either the |
JLHwung
force-pushed
the
create-ts-abstract-for-class-members
branch
from
8ae8c11 to
10a4b74
Compare
nicolo-ribaudo
approved these changes
Dec 10, 2024
liuxingbaoyu
approved these changes
Dec 11, 2024
github-actions
bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we generate
TSAbstractMethodDefinitionandTSAbstractPropertyDefinitionwhen bothestreeandtypescriptparser plugins are enabled. This PR does not affect the typescript transform / generation because none of them support theestreeparser plugin.