Skip to content

Rename TSTypeReference.typeParameters to typeArguments#17008

Merged
nicolo-ribaudo merged 4 commits into
babel:mainfrom
JLHwung:tstypereference-type-arguments
Dec 6, 2024
Merged

Rename TSTypeReference.typeParameters to typeArguments#17008
nicolo-ribaudo merged 4 commits into
babel:mainfrom
JLHwung:tstypereference-type-arguments

Conversation

@JLHwung
Copy link
Copy Markdown
Contributor

@JLHwung JLHwung commented Dec 5, 2024

Q                       A
Fixed Issues? Towards #16679
Patch: Bug Fix?
Major: Breaking Change? Yes
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#3023
Any Dependency Changes?
License MIT

In this PR we rename the typeParameters property of the TSTypeReference node to typeArguments.

This PR contains commits from #17010, please review that PR first.

@JLHwung JLHwung added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release pkg: parser PR: Needs Docs labels Dec 5, 2024
@JLHwung JLHwung added this to the v8.0.0-beta milestone Dec 5, 2024
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Dec 5, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58447

@JLHwung JLHwung force-pushed the tstypereference-type-arguments branch 2 times, most recently from 1ed5f50 to 1c5702f Compare December 6, 2024 00:36
@nicolo-ribaudo
Copy link
Copy Markdown
Member

Could you rebase? :)

@JLHwung JLHwung force-pushed the tstypereference-type-arguments branch from 1c5702f to 8907d0c Compare December 6, 2024 14:41
@nicolo-ribaudo nicolo-ribaudo changed the title rename TSTypeReference.typeParameters to typeArguments Rename TSTypeReference.typeParameters to typeArguments Dec 6, 2024
@nicolo-ribaudo nicolo-ribaudo merged commit c7f26c8 into babel:main Dec 6, 2024
@nicolo-ribaudo nicolo-ribaudo deleted the tstypereference-type-arguments branch December 6, 2024 15:30
@JLHwung JLHwung restored the tstypereference-type-arguments branch December 6, 2024 16:39
@JLHwung JLHwung deleted the tstypereference-type-arguments branch December 6, 2024 16:40
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 8, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Mar 8, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants