[react] Make development option default to the configured env#16927
Merged
Conversation
nicolo-ribaudo
added
the
PR: Bug Fix (next major) 🐛
nicolo-ribaudo
force-pushed
the
preset-react-env
branch
from
October 23, 2024 19:13
b941657 to
a983027
Compare
nicolo-ribaudo
changed the title
NODE_ENV/BABEL_ENV in preset-reactdevelopment when set through env
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58387 |
JLHwung
approved these changes
Nov 19, 2024
liuxingbaoyu
approved these changes
Dec 4, 2024
liuxingbaoyu
left a comment
liuxingbaoyu
left a comment
Member
There was a problem hiding this comment.
CI failures are relevant.
nicolo-ribaudo
force-pushed
the
preset-react-env
branch
from
December 4, 2024 10:36
a983027 to
fcaeabf
Compare
nicolo-ribaudo
changed the title
development when set through envdevelopment default to the configured env
nicolo-ribaudo
changed the title
development default to the configured envdevelopment option default to the configured env
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Babel 7 defaults to
false, while Babel 8 currently defaults totrue. We should keep defaulting tofalse, unless somebody setsNODE_ENV(orBABEL_ENV) todevelopment.