fix: Accidentally published tsconfig files
#16917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/58154 |
liuxingbaoyu
commented
Oct 19, 2024
Comment on lines
+7
to
+10
| "./babel.js", | ||
| "./babel.js.map", | ||
| "./babel.min.js", | ||
| "./babel.min.js.map" |
nicolo-ribaudo
approved these changes
Oct 19, 2024
Member
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Do you have any idea of why we started accidentally publishing them?
Member
Author
#16430 |
JLHwung
reviewed
Oct 19, 2024
| @@ -1,3 +1,4 @@ | |||
| src | |||
| test | |||
| *.log | |||
Contributor
There was a problem hiding this comment.
I suggest we keep the *.log here. In circumstances where we have to manually publish npm packages and the first publish attempt is failed, npm will generate a debug log npm-debug.log, if we forget to remove that during the second publish attempt, this log will be unfortunately published.
JLHwung
approved these changes
Oct 20, 2024
nicolo-ribaudo
added
the
PR: Internal 🏠
nicolo-ribaudo
changed the title
tsconfig files
nicolo-ribaudo
changed the title
tsconfig filestsconfig files
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We actually publish
tsconfig.jsonand eventsconfig.tsbuildinfofor all packages.🤦♂️