Skip to content

Enable unicorn/prefer-set-has rule #16822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JLHwung merged 5 commits into from
Sep 10, 2024
Merged

Enable unicorn/prefer-set-has rule #16822

JLHwung merged 5 commits into from
Sep 10, 2024

Conversation

@fisker
Copy link
Contributor

@fisker fisker commented Sep 8, 2024

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

I believe this improves performance.

@babel-bot
Copy link
Collaborator

babel-bot commented Sep 8, 2024 •
edited
Loading

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57903

@fisker fisker marked this pull request as ready for review September 8, 2024 21:59
nicolo-ribaudo
nicolo-ribaudo approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

liuxingbaoyu
liuxingbaoyu approved these changes Sep 10, 2024
View reviewed changes
Copy link
Member

@liuxingbaoyu liuxingbaoyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JLHwung JLHwung merged commit c8362e3 into babel:main Sep 10, 2024
@fisker fisker deleted the prefer-set-has branch September 10, 2024 19:05
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 11, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@liuxingbaoyu liuxingbaoyu liuxingbaoyu approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fisker @babel-bot @nicolo-ribaudo @liuxingbaoyu @JLHwung