[Babel 8] Remove enums option of flow plugin#16792
Conversation
liuxingbaoyu
added
PR: Breaking Change 💥
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57947 |
37fc336 to
8a5e70e
Compare
|
We can also do this in the next minor |
nicolo-ribaudo
added
PR: New Feature (next major) 🚀
|
Isn't this a breaking change? |
|
In which case can it break some existing usage? |
| if (process.env.BABEL_8_BREAKING) { | ||
| if (enums !== undefined) { | ||
| throw new Error( | ||
| "The .enums option has been removed and it's now always enabled. Please remove it from your config.", | ||
| ); | ||
| } | ||
| } else { | ||
| if (typeof enums !== "boolean" && typeof enums !== "undefined") { | ||
| throw new Error(".enums must be a boolean, or undefined"); | ||
| } | ||
| } |
There was a problem hiding this comment.
Now the enums option will have no effect, and we also explicitly throw an error here to align with allowDeclareFields of TS.
There was a problem hiding this comment.
We can keep the error 8-only, but enable the feature in Babel 7 too.
This ways users can start migrating now by removing the config option.
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
This looks good, but in the next minor we should enable the option by default.
405c91f to
18a0b16
Compare
There was a problem hiding this comment.
I wasn't sure the purpose of this test so just removed it.
There was a problem hiding this comment.
I think it was to make sure that we can parse valid non-TS syntax that would be invalid in TS files.
79b9393 to
3f25688
Compare
nicolo-ribaudo
added
PR: Docs 📝
github-actions
Bot
added
the
outdated
3 participants
Uh oh!
There was an error while loading. Please reload this page.