Add uncheckedRequire option for JSON imports to CJS#16579
Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom Jul 26, 2024
Merged
Add uncheckedRequire option for JSON imports to CJS#16579nicolo-ribaudo merged 2 commits intobabel:mainfrom
uncheckedRequire option for JSON imports to CJS#16579nicolo-ribaudo merged 2 commits intobabel:mainfrom
Conversation
nicolo-ribaudo
added
PR: New Feature 🚀
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57184 |
Member
Author
|
We'll need to enable this flag in our config to fix #16491. |
JLHwung
approved these changes
Jun 26, 2024
liuxingbaoyu
approved these changes
Jun 28, 2024
nicolo-ribaudo
added
the
PR: Ready to be Merged
nicolo-ribaudo
changed the title
uncheckedRequire option to transform JSON imports to require()uncheckedRequire option for JSON imports to CJS
This was referenced Aug 16, 2024
This was referenced Oct 29, 2024
This was referenced Oct 30, 2024
This was referenced Oct 31, 2024
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #16534 shows, sometimes it is impossible to properly compile
with { type: "json" }(specifically, when targeting CJS + browsers).This PR makes that case an error, providing a workaround to compile
import "x.json" with { type: "json" }to simplyrequire("x.json"). Technically this is unsound, because there could be ax.json.jsfile what gets executed without asserting that it's actually JSON, but if you are using CJS you are not loading files from the network anyway.