Move environment-visitor helper into @babel/traverse
#16577
Conversation
nicolo-ribaudo
added
the
PR: New Feature 🚀
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57359 |
JLHwung
left a comment
JLHwung
left a comment
There was a problem hiding this comment.
I recall previously we imported the traverse from their peer dependent @babel/core because of compatibility issues. Specifically we want the core, even if it is an old version, to explode any AST alias so that the traverser, imported from core, will not complain about any new AST types beyond its knowledge.
Now that visitors.environmentVisitor will explode the visitors via merge from the latest traverse, maybe we have to defer this change to Babel 8?
|
@JLHwung Most of the plugins changed in this PR already import their traverse (either from I will revert the change for the plugins that currently use the function parameter, so that we don't risk breaking something that is currently working. |
|
Actually, the only packages where we are potentially introducing the problem is I'll add a little check for it. |
nicolo-ribaudo
force-pushed
the
remove-cycles-1
branch
from
d1dfe1c to
1e3bfa5
Compare
nicolo-ribaudo
force-pushed
the
remove-cycles-1
branch
from
6ee00be to
ff3c813
Compare
|
Whops, I meant to mark as ready and I merged 😅 I guess it's fine given that we are close to a release, but I'll revert if needed. |
)" This reverts commit 25d3561.
nicolo-ribaudo
removed
the
PR: New Feature 🚀
github-actions
bot
added
the
outdated
4 participants
Fixes #1, Fixes #2I'm working on removing cycles between packages caused by type-only imports. My motivation is that, even if it's a type-only import, it's an actual conceptual cycle and those packages will always be used together anyway. For example:
@babel/traversedepends on@babel/helper-environment-visitor@babel/helper-environment-visitordoes not explicitly depend@babel/traverse, but it can only be used onNodePaths so it can only be used when@babel/traverseThis has two benefits: