[Babel 8] Remove extra.shorthand#16521
Merged
Merged
Conversation
liuxingbaoyu
added
the
PR: Internal (next major) 🏠
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57009 |
nicolo-ribaudo
approved these changes
May 22, 2024
JLHwung
approved these changes
May 30, 2024
JLHwung
left a comment
JLHwung
left a comment
Contributor
There was a problem hiding this comment.
External tools might depend on the .extra.shorthand property, can we mark this PR as a breaking change? We should also update the migration docs for this change.
nicolo-ribaudo
added
PR: Breaking Change 💥
Member
|
The recommended migration should be checking |
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2I changed testing tools to avoid a lot of duplication of tests.