-
-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Update eslint v9 #16479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update eslint v9 #16479
Conversation
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56862 |
78a1dbe to
1134f9b
Compare
.github/workflows/ci.yml
Outdated
| run: yarn up [email protected] | ||
| - name: Run babel/eslint tests | ||
| run: node ./node_modules/.bin/jest eslint | ||
| run: node ./node_modules/.bin/jest eslint/babel-eslint-parser/ eslint/babel-eslint-plugin/ babel-eslint-tests/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need this change?
Also the last one should be eslint/babel-eslint-tests/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/babel/babel/actions/runs/8980473754/job/24664241688
Our internal plugins no longer support the old eslint.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
eslint-plugin-development appears to be public, despite only having a few hundred weekly downloads, should we keep compatibility?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whops, I missed this. Yes, we should keep compatibility.
Fixes #1, Fixes #2