Skip to content

Fix order of transform-block-scoped-functions in preset-env#16475

Merged
nicolo-ribaudo merged 2 commits intobabel:mainfrom
liuxingbaoyu:block-scope-order
Dec 19, 2025
Merged

Fix order of transform-block-scoped-functions in preset-env#16475
nicolo-ribaudo merged 2 commits intobabel:mainfrom
liuxingbaoyu:block-scope-order

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

Q                       A
Fixed Issues? repl
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented May 5, 2024

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/60481

@liuxingbaoyu liuxingbaoyu added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label May 5, 2024
@liuxingbaoyu
Copy link
Copy Markdown
Member Author

The test262 failure is related, the fix and test are in #16398, we need to decide when to land it.

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

#16398 has been merged into Babel 8, but I didn't find a good way to ship a different @babel/compat-data/plugins.js.
Do you have any ideas? Thanks!

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix (next major) 🐛 A type of pull request used for our changelog categories for next major release and removed PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Dec 17, 2025
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Dec 17, 2025

Open in StackBlitz

commit: 25b954a

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

liuxingbaoyu commented Dec 17, 2025

I don't understand why there are no new successful test262 results, but the test has been fixed in the REPL.

@nicolo-ribaudo nicolo-ribaudo merged commit 3266872 into babel:main Dec 19, 2025
54 checks passed
liuxingbaoyu added a commit to liuxingbaoyu/babel that referenced this pull request Dec 28, 2025
liuxingbaoyu added a commit to liuxingbaoyu/babel that referenced this pull request Jan 6, 2026
nicolo-ribaudo pushed a commit that referenced this pull request Jan 23, 2026
* fix

* fix switch

* Revert "Fix order of `transform-block-scoped-functions` in `preset-env` (#16475)"

This reverts commit 3266872.

* clean

* fix test

* use enter

* fix
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 21, 2026
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix (next major) 🐛 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants