Remove syntaxType option for record-and-tuple (parser&plugin)
#16458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Breaking Change 💥
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56799 |
JLHwung
force-pushed
the
remove-rt-syntax-type
branch
from
7f6d472 to
71f94b0
Compare
7 tasks
JLHwung
commented
Apr 30, 2024
| sed -i 's/,"updateContext":null//g' tests/integration/__tests__/__snapshots__/debug-print-ast.js.snap | ||
| rm tests/unit/__snapshots__/visitor-keys.js.snap | ||
| # Update recordAndTuple usage | ||
| sed -i 's/\["recordAndTuple", { syntaxType: "hash" }\]/"recordAndTuple"/' src/language-js/parse/babel.js |
Contributor
Author
There was a problem hiding this comment.
/cc @fisker We plan to remove the syntaxType option in Babel 8. The syntax will always be hash.
liuxingbaoyu
approved these changes
May 1, 2024
nicolo-ribaudo
changed the title
syntaxType option from the record-and-tuple plugin and babel parsersyntaxType option for record-and-tuple (parser&plugin)
4 tasks
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we remove the
syntaxTypeoption from the@babel/plugin-proposal-record-and-tupleand the Babel parser pluginrecordAndTuplefor Babel 8.I suggest we deprecate
syntaxType: "bar"and default tosyntaxType: "hash"starting from Babel 7.25, as users will have longer time window to migrate to the hash syntax or update their Babel configs.