Skip to content

[babel 8] Cleanup plugin-transform-runtime options#16311

Merged
nicolo-ribaudo merged 3 commits into
babel:mainfrom
nicolo-ribaudo:runtime-options-cleanup
Mar 6, 2024
Merged

[babel 8] Cleanup plugin-transform-runtime options#16311
nicolo-ribaudo merged 3 commits into
babel:mainfrom
nicolo-ribaudo:runtime-options-cleanup

Conversation

@nicolo-ribaudo

@nicolo-ribaudo nicolo-ribaudo commented Feb 27, 2024

Copy link
Copy Markdown
Member
Q                       A
Fixed Issues? Fixes #16310
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2872
Any Dependency Changes?
License MIT

This PR makes @babel/plugin-transform-runtime a plugin whose sole purpose is to inject helpers. The only remaining options are:

  • absoluteRuntime
  • moduleName
  • version

This greatly simplify the surface area. Note that it still supports injecting imports to @babel/runtime-corejs3 when babel-plugin-polyfill-corejs3 is enabled, but this isn't explicitly exposed as a corejs option anymore.

This PR also stops building @babel/runtime-corejs2 in Babel 8, and marks it as private.

@babel-bot

babel-bot commented Feb 27, 2024

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/56456

@nicolo-ribaudo
nicolo-ribaudo marked this pull request as draft February 27, 2024 17:40
@nicolo-ribaudo
nicolo-ribaudo force-pushed the runtime-options-cleanup branch 3 times, most recently from 41856b7 to 10057fa Compare March 5, 2024 17:13
@nicolo-ribaudo

Copy link
Copy Markdown
Member Author

CI green :)

@nicolo-ribaudo
nicolo-ribaudo marked this pull request as ready for review March 5, 2024 17:40
@nicolo-ribaudo nicolo-ribaudo added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release and removed PR: Needs Docs babel 8 labels Mar 6, 2024
@nicolo-ribaudo
nicolo-ribaudo force-pushed the runtime-options-cleanup branch from 8b465e6 to d6a3b7b Compare March 6, 2024 14:18
@nicolo-ribaudo
nicolo-ribaudo merged commit a609d8e into babel:main Mar 6, 2024
@nicolo-ribaudo
nicolo-ribaudo deleted the runtime-options-cleanup branch March 6, 2024 18:26
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 6, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[babel 8] Cleanup @babel/plugin-transform-runtime options

4 participants