Skip to content

[babel 8] Remove CodeGenerator from @babel/generator#16126

Merged
JLHwung merged 3 commits into
babel:mainfrom
liuxingbaoyu:remove-CodeGenerator
Nov 29, 2023
Merged

[babel 8] Remove CodeGenerator from @babel/generator#16126
JLHwung merged 3 commits into
babel:mainfrom
liuxingbaoyu:remove-CodeGenerator

Conversation

@liuxingbaoyu
Copy link
Copy Markdown
Member

@liuxingbaoyu liuxingbaoyu commented Nov 25, 2023

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link babel/website#2851
Any Dependency Changes?
License MIT

class Generator extends Printer is actually useless and I removed it for performance and code cleanliness.

@liuxingbaoyu liuxingbaoyu added PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release pkg: generator labels Nov 25, 2023
@babel-bot
Copy link
Copy Markdown
Collaborator

babel-bot commented Nov 25, 2023

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55876/

@liuxingbaoyu
Copy link
Copy Markdown
Member Author

babel/website#2851
Since the CodeGenerator class is not documented, I just added the migration documentation. :)

@JLHwung JLHwung merged commit f8a98c7 into babel:main Nov 29, 2023
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 29, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Breaking Change 💥 A type of pull request used for our changelog categories for next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants