Breaking: parserOpts.createImportExpressions defaults to true#16114
Merged
Conversation
JLHwung
added
the
PR: Breaking Change 💥
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55851/ |
liuxingbaoyu
approved these changes
Nov 22, 2023
liuxingbaoyu
left a comment
liuxingbaoyu
left a comment
Member
There was a problem hiding this comment.
packages\babel-parser\typings\babel-parser.source.d.ts
Can you update it?
nicolo-ribaudo
approved these changes
Nov 22, 2023
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parserOpts.createImportExpressionsdefaults to true in Babel 8, RFC: babel/rfcs#4In this PR we defaults to parser option
createImportExpressionstotruein Babel 8. The option has been implemented in Babel 7.23 in #15682.I intend to keep this option in Babel 8 so the community has more time to prepare for the AST changes. In Babel 9 we can remove this parser option.