[babel 8] Enforce specifying proper core-js version#16095
Merged
Conversation
liuxingbaoyu
added
the
PR: Polish (next major) 💅
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/55857/ |
liuxingbaoyu
force-pushed
the
corejs-string
branch
from
November 11, 2023 11:38
3292b36 to
d271ca5
Compare
JLHwung
reviewed
Nov 21, 2023
JLHwung
approved these changes
Nov 21, 2023
nicolo-ribaudo
approved these changes
Nov 22, 2023
nicolo-ribaudo
left a comment
nicolo-ribaudo
left a comment
Member
There was a problem hiding this comment.
(this review is actually one week old, and I noticed just now that I didn't submit it 😅)
| !String(rawVersion).includes(".") | ||
| ) { | ||
| throw new Error( | ||
| "Invalid Option: The version passed to `corejs` is invalid. It must be a string with minor version, like `3.10` or `3.10.1`.", |
Member
There was a problem hiding this comment.
Suggested change
| "Invalid Option: The version passed to `corejs` is invalid. It must be a string with minor version, like `3.10` or `3.10.1`.", | |
| "Invalid Option: The version passed to `corejs` is invalid. It must be a string with minor version, like `3.33` or `3.33.2`.", |
So that people who copy-paste don't copy-paste something too old :)
Co-authored-by: Nicolò Ribaudo <[email protected]> Co-authored-by: Huáng Jùnliàng <[email protected]>
Member
|
I'm merging this, but please open a docs PR! :) |
github-actions
Bot
added
the
outdated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.